Emit multi-line logs with timestamps #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
smirnoal
approved these changes
Jan 6, 2023
|
Looks that the tests failed due to ECR rate limiting, not due to this change |
anton-stepanof
approved these changes
Jan 6, 2023
smirnoal
added a commit
to smirnoal/aws-lambda-java-libs
that referenced
this pull request
Jan 7, 2023
add timestamps to tlv (aws#393)
smirnoal
added a commit
to smirnoal/aws-lambda-java-libs
that referenced
this pull request
Jan 8, 2023
Co-authored-by: Rupayan Ghosh <[email protected]> Co-authored-by: Alexander Smirnov <[email protected]> Co-authored-by: Rupayan Ghosh <[email protected]> Co-authored-by: Rupayan Ghosh <[email protected]> Co-authored-by: Alexander Smirnov <[email protected]>
smirnoal
added a commit
to smirnoal/aws-lambda-java-libs
that referenced
this pull request
Jan 8, 2023
Co-authored-by: Rupayan Ghosh <[email protected]> Co-authored-by: Alexander Smirnov <[email protected]>
smirnoal
added a commit
to smirnoal/aws-lambda-java-libs
that referenced
this pull request
Jan 8, 2023
Co-authored-by: Rupayan Ghosh <[email protected]> Co-authored-by: Alexander Smirnov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Lambda accepts multi-line messages where the timestamp of the log emission is encoded in the log event header. This helps ordering the function emitted messages with regards to platform emitted messages, e.g. START, REPORT.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.