Support sockets as transport for framed telemetry #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smirnoal
approved these changes
Nov 15, 2022
briensea
approved these changes
Nov 15, 2022
Sockets cannot be re-opened (unlike pipes and regular files). We have to reflectively construct the `FileDescriptor` with the right number as it does not have a constructor that takes int.
anton-stepanof
approved these changes
Nov 15, 2022
|
Pushed small update - parsing integer from string can throw RuntimeException |
|
Thanks! |
|
Hello. Any ETA on when this will be released to the Maven public registry? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Socket cannot be re-opened (unlike pipes and regular files). We have to reflectively construct the
FileDescriptorwith the right number as it does not have a public constructor that takes int.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.