-
Notifications
You must be signed in to change notification settings - Fork 239
1.2.2 lambda-java-core release #367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Why is this moving from the serialization module? |
Wouldn't it also make sense to have a 4th method in the CustomSerializer: |
As discussed offline, we do not want to force cx to implement that method when creating a custom serializer. Furthermore, if they want, they can always add it to their custom serializer class. |
* Deserializes from input stream to plain old java object | ||
* @param input input stream | ||
* @param type plain old java object type | ||
* @return deserialized plain old java object of type T |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's T
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the type of the deserialized instance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the intention. But "deserialized plain old java object of type T" uses T
which is undefined and unused anywhere else.
Now, in daylight, I see. I was blind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of changes:
August 30, 2022
1.2.2
:CustomPojoSerializer
interfacepublic
on interface methods #172)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.