Skip to content

1.2.2 lambda-java-core release #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 9, 2022
Merged

1.2.2 lambda-java-core release #367

merged 3 commits into from
Nov 9, 2022

Conversation

andclt
Copy link
Contributor

@andclt andclt commented Aug 30, 2022

Description of changes:

August 30, 2022

1.2.2:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@andclt andclt requested review from msailes, smirnoal and a user August 30, 2022 17:37
@msailes
Copy link
Collaborator

msailes commented Aug 30, 2022

Why is this moving from the serialization module?

@richarddd
Copy link
Contributor

Wouldn't it also make sense to have a 4th method in the CustomSerializer:
<T> String toJson(T value, Type type);
Then the same serializer instance can be used inside handlers to create event responses requiring json strings

@andclt
Copy link
Contributor Author

andclt commented Nov 7, 2022

Wouldn't it also make sense to have a 4th method in the CustomSerializer: <T> String toJson(T value, Type type); Then the same serializer instance can be used inside handlers to create event responses requiring json strings

As discussed offline, we do not want to force cx to implement that method when creating a custom serializer. Furthermore, if they want, they can always add it to their custom serializer class.

* Deserializes from input stream to plain old java object
* @param input input stream
* @param type plain old java object type
* @return deserialized plain old java object of type T
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's T?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the type of the deserialized instance

Copy link

@pzygielo pzygielo Nov 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the intention. But "deserialized plain old java object of type T" uses T which is undefined and unused anywhere else.

Now, in daylight, I see. I was blind.

Copy link
Collaborator

@msailes msailes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andclt andclt merged commit 8696626 into aws:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants