New events structures for StreamAnalytics and CustomCheckpointing #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlzogh
approved these changes
Dec 16, 2020
There was a problem hiding this comment.
LGTM - nit: It would be nice if you could add more information about the event/response classes in terms of what integration they relate to, what they're used for, and include a link to the AWS docs that describes the integration (see some of our other events for reference).
ghost
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Added new events
DynamodbTimeWindowEventandKinesisTimeWindowEventfor supporting stream analytics.Added a couple of event response classes.
StreamsEventResponsewill be used to report batch item failures for Kinesis and Dynamodb events.TimeWindowEventResponsewill be used for returning the stream analytics state as well as reporting batch item failures forKinesisTimeWindowEventandDynamodbTimeWindowEvent.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.