Include RIC pr target in GitHub action #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlzogh
reviewed
Dec 4, 2020
.../src/test/java/com/amazonaws/services/lambda/runtime/api/client/CustomerClassLoaderTest.java
Outdated
Show resolved
Hide resolved
carlzogh
reviewed
Dec 4, 2020
aws-lambda-java-runtime-interface-client/src/main/jni/Dockerfile.glibc
Outdated
Show resolved
Hide resolved
carlzogh
approved these changes
Dec 4, 2020
carlzogh
suggested changes
Dec 4, 2020
Comment on lines
+35
to
+38
| # Test Runtime Interface Client | ||
| - name: Run 'pr' target | ||
| working-directory: ./aws-lambda-java-runtime-interface-client | ||
| run: make pr |
There was a problem hiding this comment.
Looks like this actually takes a while - I suggest we create a separate workflow that would only trigger if changes were made for the RIC (aws-lambda-java-runtime-interface-client).
There was a problem hiding this comment.
We could even take the opportunity to define a workflow per package as there is probably no need to build them all on every change.
There was a problem hiding this comment.
Creating a follow up PR for restructuring the workflow.
carlzogh
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
prtarget in GitHub action and removed the building commands that were already there since theprtarget would also build them and would generate conflictsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.