Skip to content

test module #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 10, 2020
Merged

test module #192

merged 6 commits into from
Dec 10, 2020

Conversation

jeromevdl
Copy link
Contributor

Issue #, if available:

Description of changes: New module to facilitate lambda handler unit testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jeromevdl
Copy link
Contributor Author

jeromevdl commented Dec 2, 2020

build is failing on another module...

Copy link
Contributor

@carlzogh carlzogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeromevdl this is awesome stuff! Really excited about this library, I'm sure many will be very pleased to know that there's now a Lambda library that helps them test their Lambdas locally and in CI/CD workflows!

One more thing in addition to my minor comments, could you please add top-level documentation (README.md) and a workflow step to validate the library in GH Actions (workflow)?

</plugin>
</plugins>
</build>
</project>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a release profile similar to the other libs in this project so that we can release this in the same way as we do the others? (ref. https://github.com/aws/aws-lambda-java-libs/blob/master/aws-lambda-java-events/pom.xml#L91-L151)

@jeromevdl
Copy link
Contributor Author

@carlzogh all done but jni fails in another module

Copy link
Contributor

@carlzogh carlzogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@stefanbotez stefanbotez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeromevdl jeromevdl force-pushed the aws-lambda-java-tests branch from b072a15 to f8d8c1e Compare December 10, 2020 15:12
@carlzogh carlzogh force-pushed the aws-lambda-java-tests branch from f8d8c1e to bdf82fb Compare December 10, 2020 15:13
@carlzogh carlzogh merged commit f790baa into aws:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants