-
Notifications
You must be signed in to change notification settings - Fork 239
test module #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test module #192
Conversation
build is failing on another module... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeromevdl this is awesome stuff! Really excited about this library, I'm sure many will be very pleased to know that there's now a Lambda library that helps them test their Lambdas locally and in CI/CD workflows!
One more thing in addition to my minor comments, could you please add top-level documentation (README.md) and a workflow step to validate the library in GH Actions (workflow)?
aws-lambda-java-tests/src/test/resources/apigw/events/apigw_event2.json
Outdated
Show resolved
Hide resolved
</plugin> | ||
</plugins> | ||
</build> | ||
</project> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a release
profile similar to the other libs in this project so that we can release this in the same way as we do the others? (ref. https://github.com/aws/aws-lambda-java-libs/blob/master/aws-lambda-java-events/pom.xml#L91-L151)
@carlzogh all done but jni fails in another module |
aws-lambda-java-tests/src/test/resources/sqs/sqs_event_product.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b072a15
to
f8d8c1e
Compare
f8d8c1e
to
bdf82fb
Compare
Issue #, if available:
Description of changes: New module to facilitate lambda handler unit testing.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.