Update global logger to support logging with level and arguments. #2005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philasmar
requested changes
Mar 13, 2025
| { | ||
| "Projects": [ | ||
| { | ||
| "Name": "Amazon.Lambda.RuntimeSupport", |
There was a problem hiding this comment.
Did you mean to have 2 entries for RuntimeSupport? Seems like both can be combined into 1.
There was a problem hiding this comment.
Fixed. The second one is supposed to be Amazon.Lambda.Core which I marked as preview since the API is in preview status. It will get a minor version bump once the API is out of preview.
| @@ -9,8 +12,11 @@ namespace Amazon.Lambda.Core | |||
| /// </summary> | |||
| public static class LambdaLogger | |||
| { | |||
| // Logging action, logs to Console by default | |||
| // The name of this field must not change or be readonly because Amazon.Runtime.Support will use reflection to replace the | |||
There was a problem hiding this comment.
wrong name "Amazon.Runtime.Support"
|
|
||
| #if NET6_0_OR_GREATER | ||
|
|
||
| // The name of this field must not change or be readonly because Amazon.Runtime.Support will use reflection to replace the |
There was a problem hiding this comment.
wrong name "Amazon.Runtime.Support"
| private static void LogWithLevelToConsole(string level, string message, params object[] args) | ||
| { | ||
| // Formatting here is not important, it is used for debugging Amazon.Lambda.Core only. | ||
| // In a real scenario Amazon.Runtime.Support will change the value of _loggingWithLevelAction |
There was a problem hiding this comment.
wrong name "Amazon.Runtime.Support"
|
|
||
| private const string ParameterizedPreviewMessage = | ||
| "This method has been mark as preview till the Lambda .NET Managed runtime has been updated with the backing implementation of this method. " + | ||
| "It is possible to use this method whilein preview if the Lambda function is deployed as an executable and uses the latest version of Amazon.Lambda.RuntimeSupport."; |
philasmar
approved these changes
Mar 13, 2025
GarrettBeatty
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1747 (comment)
Description of changes:
Add to the global logger
LambdaLoggerin Amazon.Lambda.Core a new parameterized logging method that takes in log level. The method is marked as preview till the new version of Amazon.Lambda.RuntimeSupport is deployed to the managed runtime.Once the PR is deployed to the managed runtime we can update
Amazon.Lambda.Logging.AspNetCoreto use this new method so the log levels will be honored.Testing
Ran tests and added an integ test cases for the new logging scenario.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.