Run jobs in CI service tests #535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfod
approved these changes
Dec 14, 2023
|
|
||
| print(f"Connecting to {cmdData.input_endpoint} with client ID '{cmdData.input_clientId}' with MQTT3...") | ||
|
|
||
| connected_future = mqtt_connection.connect() |
There was a problem hiding this comment.
I feel like futures (maybe something else, not sure) could be shared between mqtt3 and mqtt5. For example, future_connection_success can be used for mqtt3.
Comment on lines
+195
to
+196
| # To emulate working on a job, spawn a thread that sleeps for a few seconds | ||
| job_thread = threading.Thread( |
There was a problem hiding this comment.
nit: Since this is a test, this part may be simplified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run jobs in CI
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.