Skip to content

Sample and command line refactor #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Apr 19, 2023
Merged

Sample and command line refactor #441

merged 28 commits into from
Apr 19, 2023

Conversation

TwistedTwigleg
Copy link
Contributor

Description of changes:

Refactors samples not to rely on cmdUtils to setup MQTT clients, to connect/disconnect for connect samples, and overall just makes cmdUtils go back to command line parsing and nothing more.

Also contains the following minor changes:

  • Adjusts all samples to register all command line commands and get the data from said commands in a single function, rather than doing it individually in each sample.
    • This also fixed a few minor inconsistencies that slipped through: like region being used in a couple samples instead of signing_region.
  • Fixes possible Cross-SDK repository communication for PubSub by appending UUIDs to topics

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@TwistedTwigleg
Refactor basic connect not to rely on cmdData to make the connection
e900b97
@TwistedTwigleg
Refactored Greengrass Basic Discovery sample
52c9315
@TwistedTwigleg
Refactor cognito connect sample
67f81c2
@TwistedTwigleg
Refactor Cognito connect sample
abc8414
@TwistedTwigleg
Refactor Fleet Provisioning sample
5fe21d0
@TwistedTwigleg
Refactor jobs sample
ec5d896
@TwistedTwigleg
Refactor MQTT5 custom auth sample
8c65e89
@TwistedTwigleg
Refactor PKCS11 MQTT5 connect sample
ed35719
@TwistedTwigleg
Refactor MQTT5 PubSub sample
1a29967
@TwistedTwigleg
Refactor MQTT5 Shared Subscription sample
ca14240
@TwistedTwigleg
Refactor PKCS11 connect sample
3f7eb33
@TwistedTwigleg
Refactor PubSub sample
3f611af
@TwistedTwigleg
Refactor remaining samples to not rely on cmdUtils
868a84f
@TwistedTwigleg
Sample cleanup and fixes
4accb67
@TwistedTwigleg
Fix nonetype error with ports
9c1d42f
@TwistedTwigleg
Fix is_ci not parsing correctly
3b17555
@TwistedTwigleg
Typo fix
f11523d
@TwistedTwigleg
Fix missing CA processing and missing input_port in Windows Cert conn…
4defd14 
…ect sample
@TwistedTwigleg
Fix typo in X509 connect
282ab0d
@TwistedTwigleg
Hopefully last typo
316978b
@TwistedTwigleg
Add missing count
1cc01f7
@TwistedTwigleg
Properly use --region instead of --signing_region as the region argum…
f3cda46 
…ent name
@TwistedTwigleg
Revert the --region thing and properly pass the signing region in CI
d9b7f50
@TwistedTwigleg
use the right key and cert in CI for MQTT5 custom auth
d659510
@TwistedTwigleg
Forgot to register key and cert in MQTT5 custom auth...
ea1bb43
@TwistedTwigleg
More fixes
4ff14a6
@TwistedTwigleg
Make sure all PubSub samples know they are running in CI
5978ac5
xiazhvera
xiazhvera approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@xiazhvera xiazhvera left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Some trivial comments here.

@TwistedTwigleg
Copy link
Contributor Author

Thanks! Merging into main...

@TwistedTwigleg TwistedTwigleg merged commit d0ae85a into main Apr 19, 2023
@TwistedTwigleg TwistedTwigleg deleted the sample_refactor branch April 19, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiazhvera xiazhvera xiazhvera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TwistedTwigleg @xiazhvera