Skip to content

Drop support for Python 3.6 and raise minimum supported version to Py… #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,22 @@ env:
CI_DEVICE_ADVISOR: ${{ secrets.AWS_CI_DEVICE_ADVISOR_ROLE }}

jobs:
all-python-versions:
runs-on: ubuntu-latest
permissions:
id-token: write # This is required for requesting the JWT
steps:
- name: configure AWS credentials (containers)
uses: aws-actions/configure-aws-credentials@v1
with:
role-to-assume: ${{ env.CI_IOT_CONTAINERS }}
aws-region: ${{ env.AWS_DEFAULT_REGION }}
- name: Build ${{ env.PACKAGE_NAME }}
# There's hackery in builder.json so that when we run on manylinux
# we build and test using every version of python that we support.
run: |
aws s3 cp s3://aws-crt-test-stuff/ci/${{ env.BUILDER_VERSION }}/linux-container-ci.sh ./linux-container-ci.sh && chmod a+x ./linux-container-ci.sh
./linux-container-ci.sh ${{ env.BUILDER_VERSION }} aws-crt-manylinux2014-x64 build -p ${{ env.PACKAGE_NAME }}

al2:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -69,7 +85,7 @@ jobs:
run: |
aws s3 cp s3://aws-crt-test-stuff/ci/${{ env.BUILDER_VERSION }}/linux-container-ci.sh ./linux-container-ci.sh && chmod a+x ./linux-container-ci.sh
./linux-container-ci.sh ${{ env.BUILDER_VERSION }} aws-crt-${{ matrix.image }} build -p ${{ env.PACKAGE_NAME }}


windows:
runs-on: windows-latest
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ to Python by the `awscrt` package ([PyPI](https://pypi.org/project/awscrt/)) ([G
## Installation

### Minimum Requirements
* Python 3.6+
* Python 3.7+

[Step-by-step instructions](./documents/PREREQUISITES.md)

Expand Down
17 changes: 11 additions & 6 deletions builder.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,16 @@
},
"manylinux": {
"post_build_steps": [
["echo", "------ Python 3.11 ------"],
["/opt/python/cp311-cp311/bin/python", "-m", "pip", "install", "--upgrade", "pip", "setuptools"],
["/opt/python/cp311-cp311/bin/python", "-m", "pip", "install", ".", "--verbose"],
["/opt/python/cp311-cp311/bin/python", "-m", "pip", "install", "boto3", "autopep8"],
["/opt/python/cp311-cp311/bin/python", "-m", "unittest", "discover", "--verbose"],
["echo", "------ Python 3.10 ------"],
["/opt/python/cp310-cp310/bin/python", "-m", "pip", "install", "--upgrade", "pip", "setuptools"],
["/opt/python/cp310-cp310/bin/python", "-m", "pip", "install", ".", "--verbose"],
["/opt/python/cp310-cp310/bin/python", "-m", "pip", "install", "boto3", "autopep8"],
["/opt/python/cp310-cp310/bin/python", "-m", "unittest", "discover", "--verbose"],
["echo", "------ Python 3.9 ------"],
["/opt/python/cp39-cp39/bin/python", "-m", "pip", "install", "--upgrade", "pip", "setuptools"],
["/opt/python/cp39-cp39/bin/python", "-m", "pip", "install", ".", "--verbose"],
Expand All @@ -37,12 +47,7 @@
["/opt/python/cp37-cp37m/bin/python", "-m", "pip", "install", "--upgrade", "pip", "setuptools"],
["/opt/python/cp37-cp37m/bin/python", "-m", "pip", "install", ".", "--verbose"],
["/opt/python/cp37-cp37m/bin/python", "-m", "pip", "install", "boto3", "autopep8"],
["/opt/python/cp37-cp37m/bin/python", "-m", "unittest", "discover", "--verbose"],
["echo", "------ Python 3.6 ------"],
["/opt/python/cp36-cp36m/bin/python", "-m", "pip", "install", "--upgrade", "pip", "setuptools"],
["/opt/python/cp36-cp36m/bin/python", "-m", "pip", "install", ".", "--verbose"],
["/opt/python/cp36-cp36m/bin/python", "-m", "pip", "install", "boto3", "autopep8"],
["/opt/python/cp36-cp36m/bin/python", "-m", "unittest", "discover", "--verbose"]
["/opt/python/cp37-cp37m/bin/python", "-m", "unittest", "discover", "--verbose"]
],
"run_tests": false,
"_comment": "manylinux has all its own build steps, turn off 'tests' which is where normal build steps are declared. using data to program sucks"
Expand Down
2 changes: 1 addition & 1 deletion continuous-delivery/publish_to_prod_pypi.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
version: 0.2
# this image assumes Ubuntu 14.04 base image
# this image assumes Ubuntu base image
phases:
install:
commands:
Expand Down
2 changes: 1 addition & 1 deletion continuous-delivery/publish_to_test_pypi.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
version: 0.2
# this image assumes Ubuntu 14.04 base image
# this image assumes Ubuntu base image
phases:
install:
commands:
Expand Down
2 changes: 1 addition & 1 deletion documents/PREREQUISITES.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# PREREQUISITES

## Python 3.6 of higher
## Python 3.7 of higher

How you install Python varies from platform to platform. Below are the instructions for Windows, MacOS, and Linux:

Expand Down
4 changes: 2 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def _load_version():
"Operating System :: OS Independent",
],
install_requires=[
'awscrt==0.14.7',
'awscrt==0.15.2',
],
python_requires='>=3.6',
python_requires='>=3.7',
)