Skip to content

update crt to 0.14.3 #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 30, 2022
Merged

update crt to 0.14.3 #347

merged 2 commits into from
Aug 30, 2022

Conversation

xiazhvera
Copy link
Contributor

@xiazhvera xiazhvera commented Aug 29, 2022

Issue #, if available:

Description of changes:

  • Fix the mishandling of error message that "The Unknown Error Code" is being reported as "AWS_ERROR_OOM"
  • Fix connection infinite loop

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@xiazhvera xiazhvera changed the title update crt to 0.14.2 update crt to 0.14.3 Aug 30, 2022
@TwistedTwigleg
Copy link
Contributor

TwistedTwigleg commented Aug 30, 2022

Just a quick note: I looked at the C++ CRT bump and it seems to be failing the PKCS11 test. I'm not sure if we run PKCS11 on Python CI, so it might just be a C++ only CI failure, but I would wait on merging until C++ passes the PKCS11 CI test.

Edit: Disregard the above! I checked and we test PKCS11 in CI here as well, so it is all good! I just got worried over nothing 😓

@xiazhvera xiazhvera merged commit d36bc4c into main Aug 30, 2022
@xiazhvera xiazhvera deleted the crt_0_14_2 branch August 30, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants