Prevent a non-None empty username from being passed down and used to … #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…create a connection
TwistedTwigleg
approved these changes
Jul 21, 2022
| @@ -482,10 +487,10 @@ def direct_with_custom_authorizer( | |||
| else: | |||
| username_string += auth_username | |||
|
|
|||
| if not auth_authorizer_name is None: | |||
| if auth_authorizer_name is not None: | |||
There was a problem hiding this comment.
Unrelated to this PR but: We probably want to change this to != None instead of is not None because we got a GitHub issue where someone was having Python warnings in their logs using Python 3.8+ due to the use of is.
There was a problem hiding this comment.
any use of '!= None' is being auto-formatted to 'is not None' for me. We should probably tackle this as a separate issue and fix it everywhere if we fix it anywhere =]
|
Also - the check-docks issue is due to a URL being incorrect in the CI. It just needs a minor change to the CI file to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An empty string as a username causes a PRE_CONDITION in aws-c-mqtt to fail during the creation of a connection. This change will convert a completely empty username to remain None when passed down the bindings to native.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.