Skip to content

Update CONTRIBUTING to reflect how CI works in our repos #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Update CONTRIBUTING to reflect how CI works in our repos #333

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e9fe34
Update CONTRIBUTING to reflect how CI works in our repos
TwistedTwigleg Jul 13, 2022
cc942a6
Adjusted wording
TwistedTwigleg Jul 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion documents/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ To send us a pull request, please:
3. Ensure local tests pass.
4. Commit to your fork using clear commit messages.
5. Send us a pull request, answering any default questions in the pull request interface.
6. Pay attention to any automated CI failures reported in the pull request, and stay involved in the conversation.
6. Wait for a repository collaborator to look at your PR, run it in CI, test, and review. If additional changes or discussion is needed, a contributor will get back to you, so please stay invovled in the conversation.
* Note: PRs from forks will not run in CI automatically for security reasons. If you make a PR and see that CI is left pending, this is normal and expected.

GitHub provides additional document on [forking a repository](https://help.github.com/articles/fork-a-repo/) and
[creating a pull request](https://help.github.com/articles/creating-a-pull-request/).
Expand Down