Avoid warnings for using 'is' with literals in python 3.8+ #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…literals in comparisons for python 3.8+
|
Thank you for making this PR and letting us know of this change! We merged it in #335 🙂 Thanks again! Closing this PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
I'm currently seeing this in our Cloudwatch logs:
This is due to a change in python 3.8 that now reports syntax warnings for this use of
is.This PR updates
mqtt_connection_builder.pyto avoid warnings for usingiswith literals in comparisons for python 3.8+By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.