Update Greengrass V2 IPC models #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwistedTwigleg
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
Looks good to me. The differences on the model are kind of hard to read, but that is just because of how GitHub shows the differences.
There is a couple payloads that just return empty data, which I am not sure if that is intentional or not, but outside of that, everything looks good.
|
Absolutely all of this is autogenerated from our code generators which have not been modified. |
|
Gotcha. Copying over comment in C++ explaining this a bit:
In that case, this one is good to go! |
|
Thank you for the changes! Merging into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.