Skip to content

Remove developer preview warning from Greengrass V2 Client #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

MikeDombo
Copy link
Contributor

Issue #, if available:

Description of changes:
Remove developer preview warning from Greengrass V2 Client as it has been used by people for a few months now and can be considered stable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MikeDombo MikeDombo enabled auto-merge (squash) April 20, 2022 19:26
@MikeDombo MikeDombo merged commit c23328c into main Apr 20, 2022
@MikeDombo MikeDombo deleted the dev-prev-gg-v2 branch April 20, 2022 19:30
@TwistedTwigleg
Copy link
Contributor

I think we can probably remove it, but I'm somewhat hesitant because of the segmentation fault happening in a different (internal) issue that only occurs with the V2 client and not the V1 client.

@MikeDombo
Copy link
Contributor Author

MikeDombo commented Apr 20, 2022

As you're well aware, the v2 client is implemented entirely in Python/Java and not in C. It is simply using the existing code which any customer would also use, and using it in the same way that they ought to use it. Therefore, any issue and fix will be in the native code, not in the high level language.

Additionally, I believe the issue is primarily, or even only present in Java based on issues present in aws-crt-java repo.

But because of the current segfault issue, I'm not removing the warning from the Java V2 client, only Python for now.

@TwistedTwigleg
Copy link
Contributor

Noted.
I was just saying I am somewhat hesitant because it might not be stable, but I didn't see this was in Python and not Java. I do not have experience with the Python V2 client, so I trust that if you guys believe it's good, then it's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants