Skip to content

Minor fixes and polish #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Minor fixes and polish #31

merged 1 commit into from
Dec 3, 2019

Conversation

graebm
Copy link
Contributor

@graebm graebm commented Dec 3, 2019

Fixes:

  • on_connection_resumed callbacks had misnamed argument
  • GG Discovery had python-2 incompatible str->bytes conversion

Polish:

  • add kwargs to appropriate callbacks
  • misc

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- fix on_connection_resumed callbacks
- add kwargs to appropriate callbacks
- fix python 2 string encoding
- little polish stuff
@graebm graebm requested a review from a team December 3, 2019 17:03
@graebm graebm merged commit 8635538 into master Dec 3, 2019
@graebm graebm deleted the fix-sample-cb branch December 3, 2019 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants