Pub sub sample split #296
Merged
Pub sub sample split #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies command line parsing and ensures naming consistency between samples and the other AWS IoT SDKs.
Fixes the backwards compatibility issues the tests were having when trying to run on the CI.
…on-v2 into CommandLineSharedModule
…on-v2 into CommandLineSharedModule
…on-v2 into PubSubSampleSplit
…on-v2 into PubSubSampleSplit
* Added PubSub sample back to codebuild tests * Simplified connection samples by using utility functions in command_line_utils * Removed PKCS11 PubSub sample (since it's replaced by PKCS11 connect sample) * Added PKCS11 connection builder function to command_line_utils
Also adjusted the README accordingly and fixed the connect samples using the wrong titles.
sbSteveK
reviewed
Apr 1, 2022
sbSteveK
approved these changes
Apr 1, 2022
|
Thanks for the review! Merging into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Splits the pub-sub sample down into multiple smaller samples that connect using a single method, rather than having one large pub-sub sample that can connect with multiple methods. This makes it easier for users to see how to connect using each method. Comments were added to show when the pub-sub part of the samples begin, to make it easier to separate the connection part from the pub-sub part.
Also adds helper functions to the CommandLineUtils function for making a MQTT connection without needing to manually set it up, removing the MQTT connection code duplication across samples and instead allowing them to focus on showing the key feature of the sample.
Note: This PR builds on top of the command line simplification PR: #278
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.