Skip to content

Device Advisor CI automation #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 14, 2022
Merged

Device Advisor CI automation #291

merged 11 commits into from
Apr 14, 2022

Conversation

xiazhvera
Copy link
Contributor

@xiazhvera xiazhvera commented Mar 17, 2022

Description of changes:
Add the device advisor scripts to enable GitHub Actions to automatically run device advisor test on push

GitHub Setting Changes:
Added Repository secrets: AWS_DATEST_ACCESS_KEY_ID, AWS_DATEST_SECRET_ACCESS_KEY
The secrets are set to aws-sdk-common-runtime user: IotSDKDeviceAdvisorCIAutomation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

PACKAGE_NAME: aws-iot-device-sdk-python-v2
LINUX_BASE_IMAGE: ubuntu-16-x64
RUN: ${{ github.run_id }}-${{ github.run_number }}
# AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these commented lines be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave it there in case we need in future, but you are right. I will remove it before merge.

@xiazhvera xiazhvera merged commit 8cd752f into main Apr 14, 2022
@xiazhvera xiazhvera deleted the deviceadvisor_githubci branch April 14, 2022 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants