Device Advisor CI automation #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretambrose
approved these changes
Mar 18, 2022
sbSteveK
reviewed
Mar 22, 2022
.github/workflows/ci.yml
Outdated
| PACKAGE_NAME: aws-iot-device-sdk-python-v2 | ||
| LINUX_BASE_IMAGE: ubuntu-16-x64 | ||
| RUN: ${{ github.run_id }}-${{ github.run_number }} | ||
| # AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} |
There was a problem hiding this comment.
should these commented lines be removed?
There was a problem hiding this comment.
I leave it there in case we need in future, but you are right. I will remove it before merge.
sbSteveK
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add the device advisor scripts to enable GitHub Actions to automatically run device advisor test on push
GitHub Setting Changes:
Added Repository secrets: AWS_DATEST_ACCESS_KEY_ID, AWS_DATEST_SECRET_ACCESS_KEY
The secrets are set to aws-sdk-common-runtime user: IotSDKDeviceAdvisorCIAutomation
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.