Connection builder simplification #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it is no longer required to make and manage a HostResolver, EventLoopGroup, or ClientBootstrap. Also added singleton versions of all three classes and adjusted constructors to make passing a ClientBootstrap optional in many cases. Requires changes to the Python crt repository to function correctly.
TwistedTwigleg
changed the title
…on-v2 into ConnectionBuilderSimplification
This was referenced Mar 3, 2022
xiazhvera
reviewed
Mar 7, 2022
There was a problem hiding this comment.
The PR seems good to me. Just need to wait for release of awslabs/aws-crt-python#334.
xiazhvera
reviewed
Mar 15, 2022
|
Yeah, I think it is deprecated. I'll update this PR and the samples to use the latest changes (and make sure it compiles) first thing tomorrow morning 👍 |
…on-v2 into ConnectionBuilderSimplification
|
Thanks for the review! I fixed the issue with using_static_defaults, merged the latest version of master, and now all the tests pass 👍 |
xiazhvera
approved these changes
Mar 16, 2022
|
Thanks for the review! Merging into |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adjusted samples to use the changes in this PR: awslabs/aws-crt-python#334
This makes the code much smaller and removes the requirement to create and manage a HostResolver, EventLoopGroup, and ClientBootstrap to create a connection.
Requires changes the changes in the PR to function.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.