Skip to content

use latest awscrt #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 23, 2019
Merged

use latest awscrt #27

merged 9 commits into from
Oct 23, 2019

Conversation

graebm
Copy link
Contributor

@graebm graebm commented Oct 16, 2019

Update to awscrt 0.3.1

Adapt to API changes:

  • HTTP API:
    • had an extreme makeover, but that only affects the implementation of Greengrass Discovery, not its API.
  • MQTT API:
    • The Future returned by subscribe() now contains a QoS. It used to contain None.
    • on_connection_interrupted and on_connection_resumed callbacks have an extra connection argument.
  • IO API:
    • override_default_trust_store_from_path() arguments renamed

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lgtm-com
Copy link

lgtm-com bot commented Oct 16, 2019

This pull request introduces 1 alert and fixes 2 when merging 3e6c7ce into 496cec8 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 1 for Unused local variable
  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Oct 22, 2019

This pull request fixes 2 alerts when merging 55fc55e into 496cec8 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Unused import

@graebm graebm requested a review from a team October 22, 2019 21:20
Copy link
Contributor

@justinboswell justinboswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix-n-ship

@graebm graebm merged commit ea2ed17 into master Oct 23, 2019
@graebm graebm deleted the awscrt-0.3.0 branch October 23, 2019 22:02
@lgtm-com
Copy link

lgtm-com bot commented Oct 23, 2019

This pull request fixes 2 alerts when merging 2542928 into 496cec8 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Unused import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants