Json message #214
Merged
Json message #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… client shows a Message cannot be displayed in specified format. warning on strings
… client shows a Message cannot be displayed in specified format warning on strings
justinboswell
approved these changes
Jul 6, 2021
TingDaoK
reviewed
Jul 6, 2021
samples/pubsub.py
Outdated
| @@ -154,10 +155,11 @@ def on_message_received(topic, payload, dup, qos, retain, **kwargs): | |||
| publish_count = 1 | |||
| while (publish_count <= args.count) or (args.count == 0): | |||
| message = "{} [{}]".format(args.message, publish_count) | |||
| print("Publishing message to topic '{}': {}".format(args.topic, message)) | |||
| messageJson = json.dumps(message) | |||
There was a problem hiding this comment.
Trivial: For python, we usually use snake case for variables.
TingDaoK
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
if the mqtt payload is a string the AWS MQTT test client shows a "Message cannot be displayed in specified format." warning.
Description of changes:
Changed the payload to json to prevent the aforementioned warning/error.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.