-
Notifications
You must be signed in to change notification settings - Fork 222
Update samples and builder with improved proxy support #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
if (args.proxy_host): | ||
proxy_options = http.HttpProxyOptions(host_name=args.proxy_host, port=args.proxy_port) | ||
proxy_options = None | ||
if (args.proxy_host): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we check the proxy_port
is non-zero like we do in all the other languages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, nevermind, it's defaulted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
search the codebase for any other uses of websocket_proxy_options
you might have missed
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.