Skip to content

Update samples and builder with improved proxy support #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 18, 2021
Merged

Conversation

bretambrose
Copy link
Contributor

  • Update samples with improved proxy support and wording
  • Update mqtt connection builder with proxy support for direct mqtt connections

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

if (args.proxy_host):
proxy_options = http.HttpProxyOptions(host_name=args.proxy_host, port=args.proxy_port)
proxy_options = None
if (args.proxy_host):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we check the proxy_port is non-zero like we do in all the other languages?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nevermind, it's defaulted.

Copy link
Contributor

@graebm graebm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

search the codebase for any other uses of websocket_proxy_options you might have missed

@bretambrose bretambrose merged commit 3139671 into main May 18, 2021
@bretambrose bretambrose deleted the Proxy2 branch May 18, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants