Skip to content

Fix link to docs #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 4, 2020
Merged

Fix link to docs #103

merged 4 commits into from
Sep 4, 2020

Conversation

graebm
Copy link
Contributor

@graebm graebm commented Sep 4, 2020

The link from the README was wrong.

Also use default connect timeout in basic-discover sample. The shorter timeout was leading to occasional Windows CI failures.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@TingDaoK TingDaoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change to README breaks CI again.😑

@github-pages github-pages bot temporarily deployed to github-pages September 4, 2020 21:08 Inactive
@github-pages github-pages bot temporarily deployed to github-pages September 4, 2020 21:10 Inactive
this had been manually set shorter, and was often failing in CI on Windows
@github-pages github-pages bot temporarily deployed to github-pages September 4, 2020 21:15 Inactive
@graebm
Copy link
Contributor Author

graebm commented Sep 4, 2020

Why change to README breaks CI again.😑

basic_discovery.py was setting a shorter-than-usual connect timeout. I removed it so the defaults are used.

@graebm graebm merged commit 88908b5 into master Sep 4, 2020
@graebm graebm deleted the nojekyll branch September 4, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants