Failed creation of default mqtt connection

[kerenblayer]

Describe the bug

new_default_builder function in mqtt_connection_builder.py (awsiot) doesn't pass kwargs argument as expected.
It called _check_required_kwargs and _builder functions with kwargs as a single argument and not as a dictionary (**kwargs), which fails the creation of a mqtt connection.

Expected Behavior

Pass kwargs as a dictionary (**kwargs)

Current Behavior

Pass kwargs as a single argument

Reproduction Steps

mqtt_connection = mqtt_connection_builder.new_default_builder(
            endpoint=self.get_command_required(self.m_cmd_endpoint),
            port=self.get_command_required("port"),
            cert_filepath=None,
            pri_key_filepath=None,
            ca_filepath=None,
            on_connection_interrupted=on_connection_interrupted,
            on_connection_resumed=on_connection_resumed,
            client_id=self.get_command_required("client_id"),
            clean_session=False,
            keep_alive_secs=30,
            http_proxy_options=proxy_options)

Possible Solution

Fix new_default_builder function' calls (pass **kwargs instead o kwargs)

Additional Information/Context

No response

SDK version used

v2

Environment details (OS name and version, etc.)

Linux

[TwistedTwigleg]

Thank you for making this issue! I have made a PR to fix this: #341

However, in the reproduction steps provided, the connection will not work even with this fix. The default TlsContextOptions does not use a key/certificate pair, so you will need to use either mtls_from_path or mtls_from_bytes if you want to use a certificate file and a private key file to connect.

new_default_builder will not process the certificate or key file arguments, as it can only take the arguments specified at the top of the file: endpoint, client_id, client_bootstrap, on_connection_interrupted, on_connection_resumed, clean_session, reconnect_min_timeout_secs, reconnect_max_timeout_secs, keep_alive_secs, ping_timeout_ms, protocol_operation_timeout_ms, will, username, password, port, tcp_connect_timeout_ms, ca_filepath, ca_dirpath, ca_bytes, enable_metrics_collection, and http_proxy_options.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.