Scrub Python code comments #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsb42-aws
requested changes
Aug 26, 2017
| @@ -33,8 +33,8 @@ def __init__(self, **kwargs): | |||
| def _get_raw_key(self, key_id): | |||
| """Retrieves a static, randomly generated, RSA key for the specified key id. | |||
|
|
|||
| :param str key_id: Key ID | |||
| :returns: Wrapping key which contains the specified static key | |||
| :param str key_id: : User-defined ID for the static key | |||
| @@ -59,33 +59,36 @@ def _get_raw_key(self, key_id): | |||
|
|
|||
|
|
|||
| def cycle_file(key_arn, source_plaintext_filename, botocore_session=None): | |||
| """Encrypts and then decrypts a file under both a KMS Master Key Provider and a custom static Master Key Provider. | |||
| """Encrypts and then decrypts a file using a KMS master key provider and a custom static master | |||
There was a problem hiding this comment.
Spacing: The docstring for a function must be indented to the level of the contents of that function.
| static_key_id = os.urandom(8) | ||
| static_master_key_provider = StaticRandomMasterKeyProvider() | ||
| static_master_key_provider.add_master_key(static_key_id) | ||
|
|
||
| # Add Static Master Key Provider to KMS Master Key Provider | ||
| # Create a master key provider that includes the KMS and static master key providers |
There was a problem hiding this comment.
We created the KMS master key on line 81. This step adds static_master_key_provider into kms_master_key_provider. It does not create a new master key provider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.