Skip to content

Proxy KMS Client to catch BotoCoreErrors #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2018
Merged

Conversation

karlw00t
Copy link
Contributor

@karlw00t karlw00t commented Sep 24, 2018

Issue #, if available:

This is needed to remove the client from the regional client cache if a error
is detected that indicates the client has been misconfigured.

If this approach is allowed, I'll add unit tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@karlw00t karlw00t force-pushed the master branch 6 times, most recently from 0814dff to 2e9c5ae Compare September 26, 2018 20:40
Copy link
Member

@mattsb42-aws mattsb42-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor docs and organizational changes needed.

@karlw00t karlw00t force-pushed the master branch 2 times, most recently from 39bc952 to 8366932 Compare October 8, 2018 22:09
This is needed to remove the client from the regional client cache if a error
is detected that indicates the client has been misconfigured.
@mattsb42-aws mattsb42-aws merged commit f15ac2a into aws:master Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants