Skip to content

chore(keyring examples): refactor keyring examples and move master key provider examples to legacy #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 10, 2024

Conversation

RitvikKapila
Copy link
Contributor

Issue #, if available:

Description of changes:
refactor keyring examples
deprecate master_key_provider examples

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@RitvikKapila RitvikKapila requested a review from a team as a code owner May 7, 2024 23:18
@texastony
Copy link
Contributor

Note: I suggest we do not deprecate anything until we release the CachingCMM in the MPL.

@RitvikKapila RitvikKapila changed the title chore(keyring examples): refactor keyring examples and deprecate master key provider examples chore(keyring examples): refactor keyring examples May 8, 2024
@RitvikKapila RitvikKapila changed the title chore(keyring examples): refactor keyring examples chore(keyring examples): refactor keyring examples to legacy May 9, 2024
@RitvikKapila RitvikKapila changed the title chore(keyring examples): refactor keyring examples to legacy chore(keyring examples): refactor keyring examples and moving master key provider examples to legacy May 9, 2024
@RitvikKapila RitvikKapila changed the title chore(keyring examples): refactor keyring examples and moving master key provider examples to legacy chore(keyring examples): refactor keyring examples and move master key provider examples to legacy May 9, 2024
Copy link
Contributor

@lucasmcdonald3 lucasmcdonald3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Minor changes only

@RitvikKapila RitvikKapila merged commit 70d1364 into mpl-reviewed May 10, 2024
151 checks passed
@RitvikKapila RitvikKapila deleted the rkapila/keyring-examples-refactor branch May 10, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants