chore: added keyring examples (kms_rsa, multi, discovery) #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_multi_keyring_example.py
There was a problem hiding this comment.
Let's do smaller PRs next time. 5 is a little much.
If some of these were in their own PRs, they could be merged in sooner, since some of this examples are in better shape than others. Since they're all together, they're all blocked from merge by the example in worst shape.
Keep it at 2-3 examples per PR.
examples/src/keyrings/aws_kms_discovery_multi_keyring_example.py
Outdated
Show resolved
Hide resolved
examples/src/keyrings/aws_kms_discovery_multi_keyring_example.py
Outdated
Show resolved
Hide resolved
examples/src/keyrings/aws_kms_discovery_multi_keyring_example.py
Outdated
Show resolved
Hide resolved
examples/src/keyrings/aws_kms_discovery_multi_keyring_example.py
Outdated
Show resolved
Hide resolved
lucasmcdonald3
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: