Pylint 2.0.0 and a little bit of housekeeping #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat we want to ignore because we retain Python 2.7 compatibility
…at those attributes always exist
…e from referencing Algorithm to AlgorithmSuite
johnwalker
reviewed
Aug 15, 2018
| return 0 | ||
|
|
||
|
|
||
| def _verified_iv_length(iv_length, algorithm): |
There was a problem hiding this comment.
Probably makes sense to rename algorithm -> algorithm_suite. Same for any other parameters where this has changed.
There was a problem hiding this comment.
Fair point. Updated within the changed inner functions. I'm going to leave the rest as-is for now, though. At some point I would like to go through the codebase and do a more complete transition, but I think this is not the time to do that.
johnwalker
approved these changes
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #65 #17 #49
Description of changes:
In the process of updating our code to comply with the new checks in Pylint 2.0.0, I made the additional changes:
deserialize_headerlogic out into component functions.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.