-
Notifications
You must be signed in to change notification settings - Fork 86
docs: Add Thread safety section to README #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Gábor Lipták <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for cutting this PR!
I left two suggestions.
I will approve if they or something like them is committed.
Unless you find my suggestions more confusing then the original,
in which case, respond with a comment and we can try again.
Co-authored-by: Tony Knapp <[email protected]>
Co-authored-by: Tony Knapp <[email protected]>
@texastony thank you for rewording. Your edits clarified some angles so I merged them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue/Suggestion:
Oh no!
I messed up all the links and other formatting.
I thought this was a Mark Down file... but it's an rst
file.
I have made a suggestion that replaces MD formatting with rst
formatting.
I am very sorry about this back forth.
Issue #, if available:
#560 #11 (comment)
Description of changes:
Add Thread safety section to README
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: