Skip to content

docs: Add Thread safety section to README #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 24, 2023
Merged

docs: Add Thread safety section to README #562

merged 6 commits into from
Feb 24, 2023

Conversation

gliptak
Copy link
Contributor

@gliptak gliptak commented Feb 17, 2023

Issue #, if available:
#560 #11 (comment)

Description of changes:

Add Thread safety section to README

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@gliptak gliptak requested a review from a team as a code owner February 17, 2023 00:04
@gliptak gliptak changed the title Add Thread safety section to README docs: Add Thread safety section to README Feb 20, 2023
@gliptak gliptak mentioned this pull request Feb 20, 2023
Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cutting this PR!

I left two suggestions.
I will approve if they or something like them is committed.
Unless you find my suggestions more confusing then the original,
in which case, respond with a comment and we can try again.

gliptak and others added 2 commits February 21, 2023 20:41
Co-authored-by: Tony Knapp <[email protected]>
Co-authored-by: Tony Knapp <[email protected]>
@gliptak
Copy link
Contributor Author

gliptak commented Feb 22, 2023

@texastony thank you for rewording. Your edits clarified some angles so I merged them

Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue/Suggestion:
Oh no!
I messed up all the links and other formatting.
I thought this was a Mark Down file... but it's an rst file.

I have made a suggestion that replaces MD formatting with rst formatting.
I am very sorry about this back forth.

texastony
texastony previously approved these changes Feb 23, 2023
@texastony texastony merged commit 7a07b16 into aws:master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants