Skip to content

chore: Mark 1.x as End-of-Support #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 26, 2022

Conversation

texastony
Copy link
Contributor

@texastony texastony commented Aug 26, 2022

Issue #, if available: Mark 1.x as End-of-Support

Description of changes:

  • ESDK-Python emits a Deprecation warning on creation detailing 1.x is in End-of-Support
  • Added the support policy from master
  • updated the support policy from master to mark 1.x & 2.x as End-of-Support.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@texastony texastony changed the title 1.x warning client creation chore: Mark 1.x as End-of-Support Aug 26, 2022
@texastony texastony marked this pull request as ready for review August 26, 2022 00:43
@texastony texastony requested a review from a team as a code owner August 26, 2022 00:43
Copy link
Contributor

@kessplas kessplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit but LGTM.

Comment on lines +40 to +41
'This major version (1.x) of the AWS Encryption SDK for Python has reached End-of-Support.\n' +
'It will no longer receive security updates or bug fixes.\n' +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This isn't flake8 compliant, but given the circumstances, I am fine with ignoring it.

@texastony texastony merged commit c2babf8 into aws:mainline-1.x Aug 26, 2022
@texastony texastony deleted the 1.x-warning-client-creation branch August 26, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants