Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: Marking pylint results as false positive.
It looks like the int_from_bytes pylint finding is related to the deprecation of int_from_bytes in cryptography 3.4. The code will still work, but will throw deprecation warnings. I'd like to mark this as a false positive now in order to keep CI clear while we determine how to best deal with that deprecation.
The reports from
test/unit/test_streaming_client_encryption_stream.py
also appear to be false positives. From static analysis it should be clear that MockEncryptingStream inherits from _EncryptionStream, which definesnext
: https://github.com/aws/aws-encryption-sdk-python/blob/master/src/aws_encryption_sdk/streaming_client.py#L304I think that how we define the
next
hook for Python3 may be confusing the linter, though I'm not sure what recent change to pylint would have resulted in this: https://github.com/aws/aws-encryption-sdk-python/blob/master/src/aws_encryption_sdk/streaming_client.py#L319Given that these tests are asserting various expected properties from running
next
, I'm confident that these are false positives.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: