Skip to content

chore: Mark pylint false positive #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2021
Merged

Conversation

lavaleri
Copy link
Contributor

Issue #, if available:

Description of changes: Marking pylint results as false positive.

It looks like the int_from_bytes pylint finding is related to the deprecation of int_from_bytes in cryptography 3.4. The code will still work, but will throw deprecation warnings. I'd like to mark this as a false positive now in order to keep CI clear while we determine how to best deal with that deprecation.

The reports from test/unit/test_streaming_client_encryption_stream.py also appear to be false positives. From static analysis it should be clear that MockEncryptingStream inherits from _EncryptionStream, which defines next: https://github.com/aws/aws-encryption-sdk-python/blob/master/src/aws_encryption_sdk/streaming_client.py#L304

I think that how we define the next hook for Python3 may be confusing the linter, though I'm not sure what recent change to pylint would have resulted in this: https://github.com/aws/aws-encryption-sdk-python/blob/master/src/aws_encryption_sdk/streaming_client.py#L319

Given that these tests are asserting various expected properties from running next, I'm confident that these are false positives.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@lavaleri lavaleri merged commit 6f98efc into aws:master Feb 26, 2021
@lavaleri lavaleri deleted the pylint-falsepositive branch February 26, 2021 18:40
robin-aws pushed a commit to robin-aws/aws-encryption-sdk-python that referenced this pull request Apr 27, 2021
robin-aws pushed a commit that referenced this pull request Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants