Skip to content

chore: Update README section on using StrictAwsKmsKeyProvider #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 14, 2020

Conversation

farleyb-amazon
Copy link
Contributor

Be more explicit about the fact that, when using a StrictAwsKmsMasterKeyProvider, key aliases are not supported on decryption

Issue #, if available: #311

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Be more explicit about the fact that, when using a
StrictAwsKmsMasterKeyProvider, key aliases are not
supported on decryption
Copy link

@acioc acioc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just had one comment I wanted to double check below.

acioc
acioc previously approved these changes Dec 7, 2020
@farleyb-amazon
Copy link
Contributor Author

Force pushed an amended commit (no changes from original) to try to get CI to recognize that we've changed the required checks.

@farleyb-amazon farleyb-amazon merged commit 7bee34b into aws:master Dec 14, 2020
@farleyb-amazon farleyb-amazon deleted the readme-fixes branch December 14, 2020 21:44
robin-aws pushed a commit to robin-aws/aws-encryption-sdk-python that referenced this pull request Apr 27, 2021
* chore: Update README section on using StrictAwsKmsKeyProvider

Be more explicit about the fact that, when using a
StrictAwsKmsMasterKeyProvider, key aliases are not
supported on decryption

* chore: remove test requirement dependency on old versions of attrs
robin-aws pushed a commit that referenced this pull request Apr 28, 2021
* chore: Update README section on using StrictAwsKmsKeyProvider

Be more explicit about the fact that, when using a
StrictAwsKmsMasterKeyProvider, key aliases are not
supported on decryption

* chore: remove test requirement dependency on old versions of attrs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants