chore: disable the test vector handler tests in GitHub Actions #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WesleyRosenblum
approved these changes
Apr 8, 2020
It's still running in Travis, so we're not missing test execution. I'm considering turning this on to be under #207 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
I had been attempting to have the test vector handler tests only run on push and scheduled events, but that doesn't appear to have been working as expected. For now, this will just completely disable those tests. This is a housekeeping effort to avoid the current state where every PR has ~57 checks that are expected to fail.
Three of the static analysis checks are still expected to fail, but I think that handling those is more manageable and IMO it is better to let them keep failing until we can clean that up than to disable them. Having them fail reminds us that we need to fix them.
NOTE: These tests are still running as part of the Travis suite. We cannot run them in GitHub Actions until we figure out a solution to getting AWS credentials into GitHub Actions on pull requests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: