Skip to content

fix: correct KMS keyring parameter name from child_key_ids to key_ids #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2020
Merged

fix: correct KMS keyring parameter name from child_key_ids to key_ids #240

merged 2 commits into from
Apr 8, 2020

Conversation

mattsb42-aws
Copy link
Member

Issue #, if available:
resolves: #220

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

Copy link
Contributor

@WesleyRosenblum WesleyRosenblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec just refers to this as "Key Ids" which is what I called it in Java. What is it called in C and Javascript?

@mattsb42-aws
Copy link
Member Author

C calls it additional_key_ids

https://github.com/aws/aws-encryption-sdk-c/blob/749c84feddce147fb62e2ece7de34d733ef165c2/aws-encryption-sdk-cpp/include/aws/cryptosdk/cpp/kms_keyring.h#L129

JS calls it keyIds

https://github.com/aws/aws-encryption-sdk-javascript/blob/201c1022257a08c82035e5cde5097fad8321f64d/modules/kms-keyring-node/src/kms_keyring_node.ts#L42

https://github.com/aws/aws-encryption-sdk-javascript/blob/201c1022257a08c82035e5cde5097fad8321f64d/modules/kms-keyring-browser/src/kms_keyring_browser.ts#L49

I'm conflicted on the naming for this. In the context of also involving a generator key ID, I think that "additional" makes more sense because "key IDs" is just too undifferentiated. But, without the context of a generator ID, "key IDs" makes more sense because they are not in addition to anything.

@mattsb42-aws mattsb42-aws changed the title fix: correct KMS keyring parameter name from child_key_ids to additional_key_ids fix: correct KMS keyring parameter name from child_key_ids to key_ids Apr 7, 2020
@mattsb42-aws mattsb42-aws merged commit 3d98f47 into aws:keyring Apr 8, 2020
@mattsb42-aws mattsb42-aws deleted the kms-keyring-params branch April 8, 2020 00:24
@mattsb42-aws mattsb42-aws added this to the keyrings milestone Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants