chore: migrate non-integ CI to GitHub Actions workflows #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub Actions workflows
dougch
approved these changes
Mar 31, 2020
| - run: | | ||
| python -m pip install --upgrade pip | ||
| pip install --upgrade -r ci-requirements.txt | ||
| - name: run test |
There was a problem hiding this comment.
surprised there isn't a tox action yet...
|
|
||
| env: | ||
| AWS_ENCRYPTION_SDK_PYTHON_INTEGRATION_TEST_AWS_KMS_KEY_ID: | | ||
| arn:aws:kms:us-west-2:658956600833:key/b3537ef1-d8dc-4780-9f5a-55776cbb2f7f |
There was a problem hiding this comment.
assuming these are the creds already out in the wild...they aren't in the travis file
There was a problem hiding this comment.
They're CMK ARNs not creds, but for Travis and Appveyor they're set through the global environment variable settings via the web UI.
| - uses: actions/setup-python@v1 | ||
| with: | ||
| python-version: ${{ matrix.python }} | ||
| architecture: ${{ matrix.architecture }} |
mattsb42-aws
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#207
Description of changes:
Workflows running on my fork:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: