feat: add AWS KMS keyring #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seebees
reviewed
Mar 5, 2020
seebees
reviewed
Mar 5, 2020
seebees
reviewed
Mar 5, 2020
seebees
reviewed
Mar 5, 2020
seebees
reviewed
Mar 5, 2020
seebees
reviewed
Mar 5, 2020
seebees
reviewed
Mar 5, 2020
seebees
reviewed
Mar 5, 2020
seebees
reviewed
Mar 5, 2020
seebees
reviewed
Mar 5, 2020
seebees
reviewed
Mar 5, 2020
ajw-aws
previously approved these changes
Mar 6, 2020
…r than an instance of ClientSupplier
… a ClientSupplier
…ache rather than accepting a cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #146 #212
Description of changes:
This adds the AWS KMS keyring as defined in the spec[1].
Because the non-discovery KMS keyring behavior is identical to the multi-keyring behavior, rather than building this keyring from scratch, I instead reused the multikeyring internally to provide expected behavior for non-discovery modes.
[1] https://github.com/awslabs/aws-encryption-sdk-specification/blob/master/framework/kms-keyring.md
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: