Adding Travis CI config #16
Conversation
|
Travis blocks secure environment variables in builds for pull requests from forked repositories. We'll need to decide how we want to handle that so that integration tests can pass but we're not opening ourselves to security issues. Latest build from my fork: |
|
Per offline discussion, I disabled integration tests in Travis until we have a story on how we want to handle credentials for them. |
| env: TOXENV=doc8 | ||
| - python: 3.6 | ||
| env: TOXENV=readme | ||
| # pending reorg of deserialize_header |
There was a problem hiding this comment.
As discussed, flag this as TODO and link to some tracker so we don't forget?
There was a problem hiding this comment.
Issue opened to fix the underlying issue: #17
test/integration/README.rst
Outdated
| aws-encryption-sdk Integration Tests | ||
| ************************************ | ||
|
|
||
| In order to run these integration tests successfully, these things which must be configured. |
There was a problem hiding this comment.
Minor: wording polish ("these things which must be configured")
There was a problem hiding this comment.
Updated to "these things must be configured".
| """Only run tests if both required environment variables are found.""" | ||
| test_control = os.environ.get(TEST_CONTROL, None) | ||
| key_id = os.environ.get(AWS_KMS_KEY_ID, None) | ||
| return not (test_control == 'RUN' and key_id is not None) |
There was a problem hiding this comment.
Minor: not a huge deal given the context, but could be a bit more readable for maintenance's sake; even just expanding the negate out would help: test_control != 'RUN' or key_id is None (if I did that right)
There was a problem hiding this comment.
I'll be refactoring a decent chunk of the integration test utils when we get the test vectors packaged as a Python package, so I'll leave refining this bit until then.
Adding Travis CI config, adding badges to readme, and updating integration test configuration methodology from config file to environment variables (primarily to simplify in running integration tests in Travis).