Adding example one_kms_cmk #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlw00t
reviewed
Jun 4, 2019
mattsb42-aws
requested changes
Jun 4, 2019
…n-sdk-python into mmegs-examples
mattsb42-aws
requested changes
Jun 4, 2019
mattsb42-aws
requested changes
Jun 6, 2019
| import botocore.session | ||
| import pytest | ||
|
|
||
| from ..src.basic_encryption import cycle_string | ||
| from .examples_test_utils import get_cmk_arn | ||
| from .examples_test_utils import static_plaintext |
There was a problem hiding this comment.
We prefer to have all imports from the same module in the same import statement.
|
|
||
| def test_one_kms_cmk_streaming_data(): | ||
| cmk_arn = get_cmk_arn() | ||
| handle, filename = tempfile.mkstemp() |
There was a problem hiding this comment.
We don't use handle, so we should be explicit about that in its naming.
https://www.python.org/dev/peps/pep-0008/#method-names-and-instance-variables
Suggested change
| handle, filename = tempfile.mkstemp() | |
| _handle, filename = tempfile.mkstemp() |
|
The AppVeyor failures are expected, unfortunately. We need to figure out why (#159), but they're failing across the board, not just for this PR. |
…ged name of instance variable
mattsb42-aws
requested changes
Jun 10, 2019
| for f in new_files: | ||
| os.remove(f) | ||
| finally: | ||
| os.close(_handle) |
There was a problem hiding this comment.
Whoops, that was my mistake. I missed that we do actually use this. Sorry about that.
Suggested change
| os.close(_handle) | |
| os.close(handle) |
|
|
||
| def test_one_kms_cmk_streaming_data(): | ||
| cmk_arn = get_cmk_arn() | ||
| _handle, filename = tempfile.mkstemp() |
There was a problem hiding this comment.
Suggested change
| _handle, filename = tempfile.mkstemp() | |
| handle, filename = tempfile.mkstemp() |
There was a problem hiding this comment.
Changed it back
mattsb42-aws
approved these changes
Jun 10, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.