Skip to content

Threadsafety tests #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 6, 2017
Merged

Threadsafety tests #15

merged 4 commits into from
Dec 6, 2017

Conversation

mattsb42-aws
Copy link
Member

Adding integration tests to ensure that clients and LocalCryptoMaterialsCache are thread safe.

186590df9307:aws-encryption-sdk-python bullocm$ AWS_ENCRYPTION_SDK_PYTHON_INTEGRATION_TEST_CONTROL='RUN' detox -e py27,py34,py35,py36
GLOB sdist-make: /Users/bullocm/git/aws-encryption-sdk-python/setup.py
py34 inst-nodeps: /Users/bullocm/git/aws-encryption-sdk-python/.tox/dist/aws-encryption-sdk-1.3.1.zip
py35 inst-nodeps: /Users/bullocm/git/aws-encryption-sdk-python/.tox/dist/aws-encryption-sdk-1.3.1.zip
py36 inst-nodeps: /Users/bullocm/git/aws-encryption-sdk-python/.tox/dist/aws-encryption-sdk-1.3.1.zip
py27 inst-nodeps: /Users/bullocm/git/aws-encryption-sdk-python/.tox/dist/aws-encryption-sdk-1.3.1.zip
py27 runtests: PYTHONHASHSEED='815353957'
py27 runtests: commands[0] | coverage run -m pytest --cov aws_encryption_sdk
py36 runtests: PYTHONHASHSEED='815353957'     
py36 runtests: commands[0] | coverage run -m pytest --cov aws_encryption_sdk
py34 runtests: PYTHONHASHSEED='815353957'     
py34 runtests: commands[0] | coverage run -m pytest --cov aws_encryption_sdk
py35 runtests: PYTHONHASHSEED='815353957'     
py35 runtests: commands[0] | coverage run -m pytest --cov aws_encryption_sdk
__________________________________________________________________________________________________ summary ___________________________________________________________________________________________________
  py27: commands succeeded
  py34: commands succeeded
  py35: commands succeeded
  py36: commands succeeded
  congratulations :)

@mattsb42-aws mattsb42-aws requested a review from a team September 20, 2017 00:55
@mattsb42-aws mattsb42-aws mentioned this pull request Sep 20, 2017
Closed
lizroth
lizroth reviewed Dec 6, 2017
View reviewed changes
Copy link
Contributor

@lizroth lizroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests themselves seem generally fine, just a small comment about capturing intent and actual guarantee.

test/integration/test_i_thread_safety.py Outdated
# distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
# ANY KIND, either express or implied. See the License for the specific
# language governing permissions and limitations under the License.
"""Integration tests to ensure ``aws_encryption_sdk`` clients are thread safe."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to nitpick, but just in terms of capturing intent/scope/reality, these tests are more 'basic sanity check' than 'proof of thread safety'.

lizroth
lizroth approved these changes Dec 6, 2017
View reviewed changes
Copy link
Contributor

@lizroth lizroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicked through commits again, still LGTM.

@mattsb42-aws mattsb42-aws merged commit c767187 into aws:master Dec 6, 2017
@mattsb42-aws mattsb42-aws deleted the threadsafe-tests branch December 6, 2017 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizroth lizroth lizroth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsb42-aws @lizroth