Skip to content

Migrate unit/test_utils.py from unittest to pytest #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 18, 2018
Merged

Migrate unit/test_utils.py from unittest to pytest #129

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b79bb8
Migrate unit/test_utils.py from unittest to pytest
Dec 13, 2018
fdc05ff
Removed unused import and added yield and tearDown to apply_fixtures …
Dec 17, 2018
444a2ee
Made changes to fix CI travis issue
Dec 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 16 additions & 22 deletions test/unit/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,8 @@
# language governing permissions and limitations under the License.
"""Test suite for aws_encryption_sdk.internal.utils"""
import io
import unittest

import pytest
import six
from mock import MagicMock, patch, sentinel

import aws_encryption_sdk.identifiers
Expand Down Expand Up @@ -44,8 +42,9 @@ def test_prep_stream_data_wrap(source):
assert_prepped_stream_identity(test, io.BytesIO)


class TestUtils(unittest.TestCase):
def setUp(self):
class TestUtils(object):
@pytest.fixture(autouse=True)
def apply_fixtures(self):
# Set up mock key provider and keys
self.mock_key_provider_1 = MasterKeyInfo(provider_id="adijoasijfoi", key_info=b"asoiwef8q34")
self.mock_raw_data_key_1_bytes = b"asioufhaw9eruhtg"
Expand Down Expand Up @@ -139,49 +138,44 @@ def setUp(self):
)
self.mock_aws_encryption_sdk_instance.decrypt.return_value = VALUES["data_key"]
self.mock_aws_encryption_sdk_instance.encrypt.return_value = VALUES["encrypted_data_key"]

def tearDown(self):
yield
# Run tearDown
self.mock_urandom_patcher.stop()

def test_validate_frame_length_negative_frame_length(self):
"""Validate that the validate_frame_length function
behaves as expected when supplied with a
negative frame length.
"""
with six.assertRaisesRegex(
self,
SerializationError,
"Frame size must be a non-negative multiple of the block size of the crypto algorithm: *",
):
with pytest.raises(SerializationError) as excinfo:
aws_encryption_sdk.internal.utils.validate_frame_length(frame_length=-1, algorithm=self.mock_algorithm)
excinfo.match("Frame size must be a non-negative multiple of the block size of the crypto algorithm: *")

def test_validate_frame_length_invalid_frame_length(self):
"""Validate that the validate_frame_length function
behaves as expected when supplied with an
invalid frame length.
"""
with six.assertRaisesRegex(
self,
SerializationError,
"Frame size must be a non-negative multiple of the block size of the crypto algorithm: *",
):
with pytest.raises(SerializationError) as excinfo:
aws_encryption_sdk.internal.utils.validate_frame_length(frame_length=1, algorithm=self.mock_algorithm)
excinfo.match("Frame size must be a non-negative multiple of the block size of the crypto algorithm: *")

def test_validate_frame_length_too_large(self):
"""Validate that the validate_frame_length function
behaves as expected when supplied with a
frame length which is too large.
"""
with six.assertRaisesRegex(self, SerializationError, "Frame size too large: *"):
with pytest.raises(SerializationError) as excinfo:
aws_encryption_sdk.internal.utils.validate_frame_length(
frame_length=MAX_FRAME_SIZE + 1, algorithm=self.mock_algorithm
)
excinfo.match("Frame size too large: *")

def test_message_id(self):
"""Validate that the message_id function behaves as expected."""
test = aws_encryption_sdk.internal.utils.message_id()
self.mock_urandom.assert_called_once_with(MESSAGE_ID_LENGTH)
self.assertEqual(test, sentinel.random)
assert test == sentinel.random

def test_get_aad_content_string_no_framing(self):
"""Validate that the get_aad_content_string function behaves
Expand Down Expand Up @@ -214,8 +208,9 @@ def test_get_aad_content_string_framing_bad_type(self):
"""Validate that the get_aad_content_string function behaves as
expected when called with an unknown content type.
"""
with six.assertRaisesRegex(self, UnknownIdentityError, "Unhandled content type"):
with pytest.raises(UnknownIdentityError) as excinfo:
aws_encryption_sdk.internal.utils.get_aad_content_string(-1, False)
excinfo.match("Unhandled content type")

def test_prepare_data_keys(self):
mock_encryption_dk = DataKey(
Expand Down Expand Up @@ -265,9 +260,8 @@ def test_source_data_key_length_check_invalid(self):
mock_algorithm.kdf_input_len = 5
mock_data_key = MagicMock()
mock_data_key.data_key = "1234"
with six.assertRaisesRegex(
self, InvalidDataKeyError, "Invalid Source Data Key length 4 for algorithm required: 5"
):
with pytest.raises(InvalidDataKeyError) as excinfo:
aws_encryption_sdk.internal.utils.source_data_key_length_check(
source_data_key=mock_data_key, algorithm=mock_algorithm
)
excinfo.match("Invalid Source Data Key length 4 for algorithm required: 5")