Skip to content

There are no test KMS keys in any region other than us-west-1 #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
caitlin-tibbetts opened this issue Jul 26, 2019 · 1 comment
Closed

Comments

@caitlin-tibbetts
Copy link
Contributor

For the integration and example tests of the SDK, there is only a test KMS key for us-west-1, making it impossible to test cases using two different keys in different regions.

Issue found in Pull Request #177.

@caitlin-tibbetts
Copy link
Contributor Author

Found out which account to define new keys in, which fixed this issue.

mattsb42-aws added a commit that referenced this issue Mar 12, 2020
* Update PR template

* Added a check for max_age being greater than 0 (#172)

* Added a check for max_age being greater than 0

* Fixed flake8 by adding missing pydocstyle dependency

* Added the dependency to decrypt_oracle as well

* Added test for max_age<=0 ValueError

* Updated test for max_age<=0.0 ValueError

* Added negative test case

* Testing something, want AppVeyor to run

* Quick change

* Running AppVeyor

* Added example for using multiple keyrings in multiple regions

* Undid something quickly

* Fixed importerror

* Formatting fix

* Update tox.ini

* Update tox.ini

* Made some changes to the multiple_kms_cmk_regions example/test

* This is my next interation of the code for the example; however, I am still working on populating the tests correctly, so the CI will fail, but I tested the code with my own KMS CMK ARNs, so I know it will work once the tests are populated (working with Tejeswini on this)

* Changed the example to test two CMKs in the same region until Issue #178 is cleared up

* Found out how to make a new valid test key, so now there are two valid test keys in different regions for this example

* Ran autoformat

* Added some docstrings

* Formatting will be the death of me

* Used correct keys in test

* Updated some comments

* Fixed KMS master key provider tests when default AWS region is configured (#179)

* Fixed KMS master key provider tests for users who have their default AWS region configured

* created fixture for botocore session with no region set

* add auto-used fixture in KMS master key provider unit tests to test against both with and without default region

* Wrote example and test for using one kms cmk with an unsigned algorithm

* Update the integration tests

* Small changes

* Update one_kms_cmk_unsigned.py

* Update examples/src/one_kms_cmk_unsigned.py

Co-Authored-By: Matt Bullock <[email protected]>

* isort-check now succeeds

* chore: move existing examples into "legacy" directory

* chore: add automatic test runner for examples

* chore: convert existing examples to work with automatic test runner

* chore: move examples kwarg building into utils module

* chore: convert multi-CMK test runners to new configuration format

* fix: fix multi-CMK example logic

* chore: convert multi-CMK example to new test runner signature and move into legacy examples

* chore: make examples linting always run across both source and tests

* fix: linting fixes

* docs: add docstring description for legacy examples module

* chore: add initial new-format examples

* docs: add examples readme

* docs: add instructions for writing examples

* chore: address PR comments

* chore: change examples parameter from aws_kms_cmk_arn to aws_kms_cmk for consistency

* docs: clarify integration tests readme

* Apply suggestions from code review

Co-Authored-By: June Blender <[email protected]>

* Apply suggestions from code review

Co-Authored-By: June Blender <[email protected]>

* docs: change from "one-shot" term to "one-step"

* chore: apply changes based on PR comments

* docs: reword parameter description

* Apply suggestions from code review

Co-Authored-By: June Blender <[email protected]>

* chore: rename examples input parameters to move from "child" to "additional" naming

* docs: clarify configuration intro

* docs: apply examples comments consistently

* chore: fix line length

* fix: fix typo

Co-authored-by: John Walker <[email protected]>
Co-authored-by: Caitlin Tibbetts <[email protected]>
Co-authored-by: Caitlin Tibbetts <[email protected]>
Co-authored-by: Ryan Ragona <[email protected]>
Co-authored-by: lizroth <[email protected]>
Co-authored-by: June Blender <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant