Skip to content

example-node Readme.md update #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 18, 2019
Merged

example-node Readme.md update #92

merged 11 commits into from
Jun 18, 2019

Conversation

caitlin-tibbetts
Copy link
Contributor

Finished the Readme.md for the example-node module

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@juneb juneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start. If you need help explaining the KMS stuff, let me know.

@caitlin-tibbetts caitlin-tibbetts self-assigned this Jun 17, 2019
@caitlin-tibbetts caitlin-tibbetts requested a review from juneb June 18, 2019 17:59
@caitlin-tibbetts caitlin-tibbetts requested a review from juneb June 18, 2019 18:57
Copy link
Contributor

@juneb juneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nits. Great job.

@caitlin-tibbetts caitlin-tibbetts requested a review from juneb June 18, 2019 20:06
seebees
seebees previously approved these changes Jun 18, 2019
@juneb juneb dismissed stale reviews from seebees via c5bd278 June 18, 2019 21:27
@seebees seebees merged commit 497f582 into aws:master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants