initial commit kms-keyring #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seebees
commented
Mar 18, 2019
mattsb42-aws
requested changes
Mar 19, 2019
# Conflicts: # modules/kms-keyring-node/package.json # modules/kms-keyring-node/src/index.ts
kms-keyring tests kms-keyring lint kms-keyring lint
SalusaSecondus
previously approved these changes
Mar 27, 2019
mattsb42-aws
previously approved these changes
Mar 28, 2019
seebees
dismissed stale reviews from mattsb42-aws and SalusaSecondus
via
a55afd3
mattsb42-aws
requested changes
Apr 4, 2019
|
|
||
| constructor ({ clientProvider, generatorKeyId, keyIds = [], grantTokens, discovery }: KmsKeyringInput<Client>) { | ||
| super() | ||
| /* Precondition: This is an abstract class. (But TypeScript does not have a clean way to model this) */ |
There was a problem hiding this comment.
NP/commenting: this is no longer an abstract class
| /* Precondition: This is an abstract class. (But TypeScript does not have a clean way to model this) */ | ||
| needs(this.constructor !== KmsKeyring, 'new KmsKeyring is not allowed') | ||
| /* Precondition: A noop KmsKeyring is not allowed. You must explicitly set discovery or keyIds. */ | ||
| needs(!!discovery !== !!(generatorKeyId || keyIds.length), 'Noop keyring is not allowed: Set a keyId or discovery') |
There was a problem hiding this comment.
This is a confusing error message if I make the inverse: not a no-op, but instead a discovery and also key IDs.
mattsb42-aws
approved these changes
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.