feat: add client libraries #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding `client-node` and `client-browser` * Update `example-node` modules to use`client-node` * Update `integration-node ` modules to use `client-node` * Update `integration-browser` modules to use `client-browser`
lizroth
approved these changes
Jun 14, 2019
|
|
||
| This module is for encryption and decryption in Node.js. | ||
| It is a composition of underlying modules. | ||
| It is intended to have every component of the AWS Encryption SDK. |
There was a problem hiding this comment.
NP: Every? Would it be better to explain this in the context of the desired outcome? e.g. It is intended to have every component of the AWS Encryption SDK required to work with encrypting and decrypting messages in our message format using any key source we support?
| @@ -13,5 +13,5 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| export { decrypt, DecryptResult } from './decrypt' | |||
| export * from './decrypt' | |||
There was a problem hiding this comment.
IANAJS developer: is this good practice or is being more explicit preferred?
There was a problem hiding this comment.
In this case no. The reason I changed this is that some types were not being exported and this was causing TypeScript to complain about portability.
I'm moving to have things that are 'private' in the module in their own file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client-nodeandclient-browserexample-nodemodules to useclient-nodeintegration-nodemodules to useclient-nodeintegration-browsermodules to useclient-browserBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.