Skip to content

feat: Message ID should be defined in serialize #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 13, 2019
Merged

feat: Message ID should be defined in serialize #88

merged 3 commits into from
Jun 13, 2019

Conversation

seebees
Copy link
Contributor

@seebees seebees commented Jun 11, 2019

These values should not be numbers floating in code.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@seebees seebees requested a review from a team June 11, 2019 21:59
@mattsb42-aws
Copy link
Member

This LGTM, but it needs to be updated against master.

@seebees seebees merged commit cc167c5 into aws:master Jun 13, 2019
@seebees seebees deleted the message_id_constant branch June 13, 2019 22:02
@seebees seebees mentioned this pull request Sep 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizroth lizroth lizroth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seebees @mattsb42-aws @lizroth