Skip to content

Release improvements #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 4, 2021
Merged

Conversation

farleyb-amazon
Copy link
Contributor

Description of changes:
Add codebuild spec for releasing.

Testing:
I've successfully run the codebuild spec with all of the steps except the npx lerna publish command.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- npm install otplib --no-save
- npm run build
runtime-versions:
nodejs: 10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nodejs: 10
nodejs: 14

- npm run verdaccio
# Generate new version and CHANGELOG entry. Because we specify `--no-push` this
# does not yet push any changes to the remote
- npx lerna version --conventional-commits --git-remote origin --yes --no-push
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do want to push here

# Log the commit for posterity
- git log -n 1
# Publish to the local verdaccio server and run all tests
- npm run verdaccio-publish
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better tested at npm run verdaccio

@farleyb-amazon farleyb-amazon merged commit 83325c8 into aws:master Jun 4, 2021
@farleyb-amazon farleyb-amazon deleted the release-improvements branch June 4, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants