-
Notifications
You must be signed in to change notification settings - Fork 63
Release improvements #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release improvements #618
Conversation
codebuild/release/prod-release.yml
Outdated
- npm install otplib --no-save | ||
- npm run build | ||
runtime-versions: | ||
nodejs: 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nodejs: 10 | |
nodejs: 14 |
codebuild/release/prod-release.yml
Outdated
- npm run verdaccio | ||
# Generate new version and CHANGELOG entry. Because we specify `--no-push` this | ||
# does not yet push any changes to the remote | ||
- npx lerna version --conventional-commits --git-remote origin --yes --no-push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do want to push here
codebuild/release/prod-release.yml
Outdated
# Log the commit for posterity | ||
- git log -n 1 | ||
# Publish to the local verdaccio server and run all tests | ||
- npm run verdaccio-publish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is better tested at npm run verdaccio
Description of changes:
Add codebuild spec for releasing.
Testing:
I've successfully run the codebuild spec with all of the steps except the
npx lerna publish
command.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.