Skip to content

chore: upgrade dev dependencies for karma credential management #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2021

Conversation

texastony
Copy link
Contributor

@texastony texastony commented Apr 2, 2021

Issue #, if available: None

Description of changes: Chore: Upgrade aws-sdk provided karma credentials.

The specific commands:

npm install @aws-sdk/credential-provider-node@latest --save-dev
npm install @aws-sdk/karma-credential-loader@latest --save-dev
npm install @aws-sdk/util-base64-browser@latest --save-dev

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

upgrade @aws-sdk/credential-provider-node to 3.11.0
upgrade @aws-sdk/karma-credential-loader to 3.11.0
upgrade @aws-sdk/util-base64-browser to 3.10.0
Copy link
Contributor

@seebees seebees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seebees seebees changed the title Chore karma credentials chore: upgrade dev dependencies for karma credential management Apr 2, 2021
@seebees
Copy link
Contributor

seebees commented Apr 2, 2021

We can do it when we squash the commits, but can you include the specific commands you ran please :)

@texastony
Copy link
Contributor Author

Looking into why the Code Build failed... I see one Test failed during the browser/integration tests... so hopefully a time out.

@texastony
Copy link
Contributor Author

Updated the PR Request with commands ran.

@texastony texastony merged commit 744e42c into aws:master Apr 2, 2021
robin-aws pushed a commit that referenced this pull request Apr 23, 2021
* Chore: upgrade development dependencies for karma credential management

upgrade aws-sdk/credential-provider-node to 3.11.0, aws-sdk/karma-credential-loader to 3.11.0, and aws-sdk/util-base64-browser to 3.10.0 via:

npm install @aws-sdk/credential-provider-node@latest --save-dev
npm install @aws-sdk/karma-credential-loader@latest --save-dev
npm install @aws-sdk/util-base64-browser@latest --save-dev

* Correct Typo;  Ignore JetBrain/IntelliJ files
@texastony texastony deleted the chore_karma_credentials branch October 28, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants