chore: Use lerna fixed versioning #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: https://github.com/lerna/lerna#fixedlocked-mode-default 1. Currently the SDK create a new tag for each new version each subpackage. This results in having too many tags to maintain. 2. Using independent versioning also adds some unnecessary complexity over the release system. 3. Most popular monorepos use fixed versioning, like Lerna, Babel See: aws-sdk-js-v3 switched to fixed versioning with their release candidate in aws/aws-sdk-js-v3#1248
farleyb-amazon
previously approved these changes
Jan 28, 2021
robin-aws
approved these changes
Jun 4, 2021
seebees
added a commit
to seebees/aws-sdk-js-crypto-helpers-1
that referenced
this pull request
Sep 10, 2021
Reference: https://github.com/lerna/lerna#fixedlocked-mode-default 1. Currently the SDK create a new tag for each new version each subpackage. This results in having too many tags to maintain. 2. Using independent versioning also adds some unnecessary complexity over the release system. 3. Most popular monorepos use fixed versioning, like Lerna, Babel See: aws-sdk-js-v3 switched to fixed versioning with their release candidate in aws/aws-sdk-js-v3#1248 And aws/aws-encryption-sdk-javascript#523
seebees
added a commit
to aws/aws-sdk-js-crypto-helpers
that referenced
this pull request
Sep 13, 2021
Reference: https://github.com/lerna/lerna#fixedlocked-mode-default 1. Currently the SDK create a new tag for each new version each subpackage. This results in having too many tags to maintain. 2. Using independent versioning also adds some unnecessary complexity over the release system. 3. Most popular monorepos use fixed versioning, like Lerna, Babel A tag for v1.1.1 will be created pointing to this release, for the last published version that was 86ad0b6 See: aws-sdk-js-v3 switched to fixed versioning with their release candidate in aws/aws-sdk-js-v3#1248 And aws/aws-encryption-sdk-javascript#523
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: https://github.com/lerna/lerna#fixedlocked-mode-default
See: aws-sdk-js-v3 switched to fixed versioning with their release candidate in aws/aws-sdk-js-v3#1248
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: